Hi Ferruh, On Mon, Mar 26, 2018 at 07:39:00PM +0100, Ferruh Yigit wrote: > On 2/27/2018 3:11 PM, Olivier Matz wrote: > > Change the prototype and the behavior of dev_ops->eth_mac_addr_set(): a > > return code is added to notify the caller (librte_ether) if an error > > occurred in the PMD. > > > > The new default MAC address is now copied in dev->data->mac_addrs[0] > > only if the operation is successful. > > > > The patch also updates all the PMDs accordingly. > > > > Signed-off-by: Olivier Matz <olivier.m...@6wind.com>
[...] > ethdev part looks good to me. > Are you planning to have another version for mrvl and sfc comments? > > PMD maintainers, please check and provide feedback for your PMD, otherwise the > patch will go in as it is. Yes, I'll send a new version adressing the comments as soon as possible. Thanks, Olivier
