On Tue, Mar 27, 2018 at 05:55:32AM +0000, Shahaf Shuler wrote:
> Monday, March 26, 2018 2:18 PM, Nélio Laranjeiro:
> > On Mon, Mar 26, 2018 at 01:12:18PM +0300, Shahaf Shuler wrote:
> > > @@ -48,6 +48,13 @@ mlx5_rss_hash_update(struct rte_eth_dev *dev,
> > > return -rte_errno;
> > > }
> > > if (rss_conf->rss_key && rss_conf->rss_key_len) {
> > > + if (rss_conf->rss_key_len != rss_hash_default_key_len) {
> > > + DRV_LOG(ERR,
> > > + "port %u RSS key len must be %zu Bytes
> > long",
> > > + dev->data->port_id,
> > rss_hash_default_key_len);
> > > + rte_errno = ENOTSUP;
> >
> > Should be EINVAL when values are incorrect.
>
> OK.
>
> Considering it is the only comment in this series, are you OK with me
> changing it while applying to next-net-mlx?
Sure,
Acked-by: Nelio Laranjeiro <nelio.laranje...@6wind.com>
--
Nélio Laranjeiro
6WIND
