Hi Anatoly, Looks good, see inline for details. Acked-by: John Daley <johnd...@cisco.com>
Thanks, John > -----Original Message----- > From: Anatoly Burakov [mailto:anatoly.bura...@intel.com] > Sent: Saturday, March 03, 2018 5:46 AM > To: dev@dpdk.org > Cc: John Daley (johndale) <johnd...@cisco.com>; Hyong Youb Kim (hyonkim) > <hyon...@cisco.com>; keith.wi...@intel.com; jianfeng....@intel.com; > andras.kov...@ericsson.com; laszlo.vadk...@ericsson.com; > benjamin.wal...@intel.com; bruce.richard...@intel.com; > tho...@monjalon.net; konstantin.anan...@intel.com; > kuralamudhan.ramakrish...@intel.com; louise.m.d...@intel.com; > nelio.laranje...@6wind.com; ys...@mellanox.com; peppe...@japf.ch; > jerin.ja...@caviumnetworks.com; hemant.agra...@nxp.com; > olivier.m...@6wind.com > Subject: [PATCH 37/41] net/enic: use contiguous allocation for DMA memory > > Signed-off-by: Anatoly Burakov <anatoly.bura...@intel.com> > --- > > Notes: > It is not 100% clear that second call to memzone_reserve > is allocating DMA memory. Corrections welcome. The 2nd call is allocating DMA memory so I believe your patch is correct. > > drivers/net/enic/enic_main.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/net/enic/enic_main.c b/drivers/net/enic/enic_main.c index > ec9d343..cb2a7ba 100644 > --- a/drivers/net/enic/enic_main.c > +++ b/drivers/net/enic/enic_main.c > @@ -319,7 +319,7 @@ enic_alloc_consistent(void *priv, size_t size, > struct enic *enic = (struct enic *)priv; > struct enic_memzone_entry *mze; > > - rz = rte_memzone_reserve_aligned((const char *)name, > + rz = rte_memzone_reserve_aligned_contig((const char *)name, > size, SOCKET_ID_ANY, 0, > ENIC_ALIGN); > if (!rz) { > pr_err("%s : Failed to allocate memory requested for %s\n", > @@ -787,7 +787,7 @@ int enic_alloc_wq(struct enic *enic, uint16_t queue_idx, > "vnic_cqmsg-%s-%d-%d", enic->bdf_name, queue_idx, > instance++); > > - wq->cqmsg_rz = rte_memzone_reserve_aligned((const char *)name, > + wq->cqmsg_rz = rte_memzone_reserve_aligned_contig((const char > *)name, > sizeof(uint32_t), > SOCKET_ID_ANY, 0, > ENIC_ALIGN); This is a send completion landing spot which is DMA'd to by the NIC so it does have to be contiguous. However the size is only 4 bytes so it might not matter. > -- > 2.7.4
