On 03/05/2018 12:08 PM, Burakov, Anatoly wrote:
On 03-Mar-18 2:05 PM, Andrew Rybchenko wrote:
On 03/03/2018 04:46 PM, Anatoly Burakov wrote:
This fixes the following drivers in one go:
Does it mean that these drivers are broken in the middle of patch set
and fixed now?
If so, it would be good to avoid it. It breaks bisect.
Depends on the definition of "broken". Legacy memory mode will still
work for all drivers throughout the patchset. As for new memory mode,
yes, it will be "broken in the middle of the patchset", but due to the
fact that there's enormous amount of code to review between fbarray
changes, malloc changes, contiguous allocation changes and adding new
rte_memzone API's, i favored ease of code review over bisect.
I can of course reorder and roll up several different patchset and all
driver updates into one giant patch, but do you really want to be the
one reviewing such a patch?
Is it possible to:
1. Introduce _contig function
2. Switch users of the contiguous allocation to it as you do now
3. Make the old function to allocate possibly non-contiguous memory
