On 1/17/2018 2:04 PM, Moti Haimovsky wrote: > Ethdev Rx offloads API has changed since: > commit ce17eddefc20 ("ethdev: introduce Rx queue offloads API") > This commit adds support for the new Rx offloads API. > > Signed-off-by: Moti Haimovsky <mo...@mellanox.com>
<...> > +static bool > +tap_rxq_are_offloads_valid(struct rte_eth_dev *dev, uint64_t offloads) > +{ > + uint64_t port_offloads = dev->data->dev_conf.rxmode.offloads; > + uint64_t queue_supp_offloads = tap_rx_offload_get_queue_capa(); > + uint64_t port_supp_offloads = tap_rx_offload_get_port_capa(); > + > + if ((offloads & (queue_supp_offloads | port_supp_offloads)) != > + offloads) > + return false; > + if ((port_offloads ^ offloads) & port_supp_offloads) > + return false; Hi Moti, I am getting following error when tried to use tap with bonding: "Rx queue offloads 0x0 don't match port offloads 0x1000 or supported offloads 0x300e" What is the intention here? I guess it tries to be sure requested queue offloads is subsets of port_offloads and offload_capability. If so not requesting any queue offload should be valid, isn't it? <...>