HI Pavan,

On 2/12/2018 7:53 PM, Pavan Nikhilesh wrote:
Remove some unused map symbol.

Signed-off-by: Pavan Nikhilesh <pbhagavat...@caviumnetworks.com>
---
<snip..>
diff --git a/drivers/mempool/dpaa/rte_mempool_dpaa_version.map 
b/drivers/mempool/dpaa/rte_mempool_dpaa_version.map
index cc635c736..d05f274d0 100644
--- a/drivers/mempool/dpaa/rte_mempool_dpaa_version.map
+++ b/drivers/mempool/dpaa/rte_mempool_dpaa_version.map
@@ -2,7 +2,6 @@ DPDK_17.11 {
        global:
rte_dpaa_bpid_info;
-       rte_dpaa_pool_table;
local: *;
  };

DPAA(x) related changes LGTM

diff --git a/lib/librte_eal/rte_eal_version.map 
b/lib/librte_eal/rte_eal_version.map
index 2e6cbe96e..d12360235 100644
--- a/lib/librte_eal/rte_eal_version.map
+++ b/lib/librte_eal/rte_eal_version.map
@@ -248,7 +248,6 @@ EXPERIMENTAL {
        rte_service_map_lcore_get;
        rte_service_map_lcore_set;
        rte_service_probe_capability;
-       rte_service_reset;

It is not a good idea to remove these APIs form MAP
Some of these are external APIs. The existing examples may not be using them in DPDK, but a real app may use that. The same comment apply to other removal for external APIs.

Cristian, what is your opinion.

        rte_service_run_iter_on_app_lcore;
        rte_service_runstate_get;
        rte_service_runstate_set;
diff --git a/lib/librte_ether/rte_ethdev_version.map 
b/lib/librte_ether/rte_ethdev_version.map
index a5cb372b1..87f02fb74 100644
--- a/lib/librte_ether/rte_ethdev_version.map
+++ b/lib/librte_ether/rte_ethdev_version.map
@@ -156,7 +156,6 @@ DPDK_17.08 {
        rte_flow_copy;
        rte_flow_isolate;
        rte_tm_capabilities_get;
-       rte_tm_get_leaf_nodes;
        rte_tm_hierarchy_commit;
        rte_tm_level_capabilities_get;
        rte_tm_mark_ip_dscp;
diff --git a/lib/librte_ring/rte_ring_version.map 
b/lib/librte_ring/rte_ring_version.map
index 5474b985e..d935efd0d 100644
--- a/lib/librte_ring/rte_ring_version.map
+++ b/lib/librte_ring/rte_ring_version.map
@@ -7,7 +7,6 @@ DPDK_2.0 {
        rte_ring_init;
        rte_ring_list_dump;
        rte_ring_lookup;
-       rte_ring_set_water_mark;
local: *;
  };


Reply via email to