> -----Original Message----- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Tomasz Kulasek > Sent: Friday, February 9, 2018 1:00 AM > To: y...@fridaylinux.org > Cc: dev@dpdk.org; yuanhan....@linux.intel.com; sta...@dpdk.org; > Wodkowski, PawelX > Subject: [dpdk-dev] [PATCH] vhost: fix offset while mmaping log base > address > > QEMU always set offset to 0 but for sanity we should take the offset > into account. > > Fixes: 54f9e32305d4 ("vhost: handle dirty pages logging request") > Cc: yuanhan....@linux.intel.com > Cc: sta...@dpdk.org > > Signed-off-by: Pawel Wodkowski <pawelx.wodkow...@intel.com> > Signed-off-by: Tomasz Kulasek <tomaszx.kula...@intel.com>
Reviewed-by: Jianfeng Tan <jianfeng....@intel.com> Thanks! > --- > lib/librte_vhost/vhost_user.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/lib/librte_vhost/vhost_user.c b/lib/librte_vhost/vhost_user.c > index 65ee33919..674f2ffe8 100644 > --- a/lib/librte_vhost/vhost_user.c > +++ b/lib/librte_vhost/vhost_user.c > @@ -991,7 +991,7 @@ vhost_user_set_log_base(struct virtio_net *dev, > struct VhostUserMsg *msg) > * mmap from 0 to workaround a hugepage mmap bug: mmap will > * fail when offset is not page size aligned. > */ > - addr = mmap(0, size, PROT_READ | PROT_WRITE, MAP_SHARED, fd, > 0); > + addr = mmap(0, size + off, PROT_READ | PROT_WRITE, > MAP_SHARED, fd, 0); > close(fd); > if (addr == MAP_FAILED) { > RTE_LOG(ERR, VHOST_CONFIG, "mmap log base failed!\n"); > -- > 2.14.1