07/02/2018 08:05, Chao Zhu: > The previous patch has some misunderstanding of the the TSC frequency > counting. > I support this.
Chao, it is very late in the release cycle. Do you want to take the risk of applying this patch in 18.02-rc4? If you discover a bug in this patch next week, it will be too late for fixing it in 18.02. > > -----Original Message----- > > From: Thomas Monjalon [mailto:tho...@monjalon.net] > > Sent: 2018年2月1日 8:30 > > To: Gowrishankar <gowrishanka...@linux.vnet.ibm.com>; Chao Zhu > > <chao...@linux.vnet.ibm.com> > > Cc: dev@dpdk.org > > Subject: Re: [dpdk-dev] [PATCH] eal/ppc64: revert implement arch-specific > TSC > > freq query > > > > 30/01/2018 09:59, Gowrishankar: > > > From: Gowrishankar Muthukrishnan <gowrishanka...@linux.vnet.ibm.com> > > > > > > This reverts commit 15692396fd68932b6a81f00f12d4b0da12baa7d3 > > > (eal/ppc64: implement arch-specific TSC freq query). We intended to > > > derive pkt/sec estimation with cpu clock frequency. As timebase > > > register serves the timer purpose, we need to stick with it for > > > calculating pkt/sec, hence reverting the change. > > > > > > Fixes: 15692396fd (eal/ppc64: implement arch-specific TSC freq query) > > > > It is not clear what it is fixing. > > > > Chao, please review. > >
