> Input validation is not applied consistently in vhost_user.c. This suggests > that > not everyone has the same security model in mind when working on the > code. > > Make the security model explicit so that everyone can understand and follow > the same model when modifying the code. > > Signed-off-by: Stefan Hajnoczi <stefa...@redhat.com> > --- > lib/librte_vhost/vhost_user.c | 17 +++++++++++++++++ > 1 file changed, 17 insertions(+) > > diff --git a/lib/librte_vhost/vhost_user.c b/lib/librte_vhost/vhost_user.c
<...> This is a useful comment but I don't know if it makes sense to include it in the vhost_user.c file. Particularly at the top where it looks like a general descriptive comment for the file. It would probably be better in the vhost-user section of the programmer's guide: http://dpdk.org/doc/guides/prog_guide/vhost_lib.html Also, the subject line shouldn't include an underscore. Marko
