Re: [dpdk-dev] [PATCH v3] eal: add function to return number of detected sockets

[Burakov, Anatoly]

On 05-Feb-18 4:37 PM, Anatoly Burakov wrote:
During lcore scan, find maximum socket ID and store it.
Signed-off-by: Anatoly Burakov <anatoly.bura...@intel.com>
---

Notes:
     v3:
     - Added ABI backwards compatibility
     
     v2:
     - checkpatch changes
     - check socket before deciding if the core is not to be used

  lib/librte_eal/common/eal_common_lcore.c  | 37 +++++++++++++++++++++----------
  lib/librte_eal/common/include/rte_eal.h   | 25 +++++++++++++++++++++
  lib/librte_eal/common/include/rte_lcore.h |  8 +++++++
  lib/librte_eal/linuxapp/eal/eal.c         | 27 +++++++++++++++++++++-
  lib/librte_eal/rte_eal_version.map        |  9 +++++++-
  5 files changed, 92 insertions(+), 14 deletions(-)


This patch does not break ABI, but does it in a very ugly way. Is it 
worth it?

--
Thanks,
Anatoly