> -----Original Message----- > From: Nipun Gupta > Sent: Monday, February 5, 2018 10:52 AM > To: tho...@monjalon.net; jerin.ja...@caviumnetworks.com > Cc: dev@dpdk.org; santosh.shu...@caviumnetworks.com; Hemant Agrawal > <hemant.agra...@nxp.com>; Shreyansh Jain <shreyansh.j...@nxp.com>; > Sunil Kumar Kori <sunil.k...@nxp.com>; Nipun Gupta > <nipun.gu...@nxp.com> > Subject: [PATCH 2/4] bus/dpaa: fix registering dpaa mempool ops > > Fixes: 2bd0d5b951a9 ("bus/dpaa: register platform HW mempool on > runtime") > > Signed-off-by: Nipun Gupta <nipun.gu...@nxp.com> > --- > drivers/bus/dpaa/dpaa_bus.c | 8 +++++++- > 1 file changed, 7 insertions(+), 1 deletion(-) > > diff --git a/drivers/bus/dpaa/dpaa_bus.c b/drivers/bus/dpaa/dpaa_bus.c > index 1946bbe..290b967 100644 > --- a/drivers/bus/dpaa/dpaa_bus.c > +++ b/drivers/bus/dpaa/dpaa_bus.c > @@ -495,10 +495,16 @@ int rte_dpaa_portal_fq_close(struct qman_fq *fq) > ret = drv->probe(drv, dev); > if (ret) > DPAA_BUS_ERR("Unable to probe.\n"); > + > break; > } > } > - rte_mbuf_set_platform_mempool_ops(DPAA_MEMPOOL_OPS_NAME); > + > + /* Register DPAA mempool ops only if any DPAA device has > + * been detected. > + */ > + if (!TAILQ_EMPTY(&rte_dpaa_bus.device_list)) > + > rte_mbuf_set_platform_mempool_ops(DPAA_MEMPOOL_OPS_NAME); > > svr_file = fopen(DPAA_SOC_ID_FILE, "r"); > if (svr_file) { > -- > 1.9.1 >
Just a note: there is an extra line insertion in this patch which is not related to the patch fix. Though, I think that makes the code more readable as preceding if() for this new line is without {}. Acked-by: Shreyansh Jain <shreyansh.j...@nxp.com>