On Tue, Jan 23, 2018 at 01:15:56PM +0000, Andrew Rybchenko wrote: > There is not specified dependency between rte_mempool_populate_default() > and rte_mempool_populate_iova(). So, the second should not rely on the > fact that the first adds capability flags to the mempool flags. > > Fixes: 65cf769f5e6a ("mempool: detect physical contiguous objects") > Cc: sta...@dpdk.org > > Signed-off-by: Andrew Rybchenko <arybche...@solarflare.com>
Looks good to me. I agree it's strange that the mp->flags are updated with capabilities only in rte_mempool_populate_default(). I see that this behavior is removed later in the patchset since the get_capa() is removed! However maybe this single patch could go in 18.02. +Santosh +Jerin since it's mostly about Octeon.