Tuesday, January 30, 2018 11:40 AM, Adrien Mazarguil: > Unfortunately I didn't get a chance to review this patch before it was > applied. > I'm not sure a stopped port is supposed to report events (interrupts). Will > applications expect them to occur at this point?
Why not? Stopped port is still counted as attached. The fact the application stopped the packet receive on it doesn't mean it should not receive a sync events (such as the remove event). async events, by definition, are not related to traffic being flows through the port. > > In my opinion it's not a fix, as in, it doesn't address an issue introduced > by the > mentioned patch whose behavior was correct. > > It's probably too late to change it now and it does address an issue seen with > a use case involving this PMD, however I think the fail-safe PMD could as well > poll using the recently-added rte_eth_dev_is_removed() when it's aware > the underlying port is stopped instead of expecting interrupts. > > -- > Adrien Mazarguil > 6WIND
