On Thu, Jan 25, 2018 at 01:58:32PM +0000, Ferruh Yigit wrote: > On 1/23/2018 4:22 PM, Pavan Nikhilesh wrote: > > Disable for clang < 4.0 as it doesn't support the following > > arm machine directives: > > > > .cpu > > > > This also disables event octeontx as it depends on net octeontx. > > > > Signed-off-by: Pavan Nikhilesh <pbhagavat...@caviumnetworks.com> > > <...> > > > @@ -20,3 +20,8 @@ CLANG_MINOR_VERSION := $(shell echo $(CLANG_VERSION) | > > cut -f2 -d.) > > ifeq ($(shell test $(CLANG_MAJOR_VERSION)$(CLANG_MINOR_VERSION) -lt 35 && > > echo 1), 1) > > CC_SUPPORTS_Z := false > > endif > > + > > +ifeq ($(shell test $(CLANG_MAJOR_VERSION)$(CLANG_MINOR_VERSION) -lt 40 && > > echo 1), 1) > > + CONFIG_RTE_LIBRTE_OCTEONTX_PMD=d > > + CONFIG_RTE_LIBRTE_PMD_OCTEONTX_SSOVF=d > > +endif > > I remember we did this before but this is ugly. > > Can it be done in a generic way that compiler dependencies defined in the PMD > Makefile and during config PMD may be disable based on dependency and > environment. If there is no dependency PMD will not do anything special, does > it > make sense?
Makes sense, Will disable compiler dependent code in PMD makefile. Thanks, Pavan.
