Hi Morten, On Wed, Jan 17, 2018 at 10:20:53PM +0100, Morten Brørup wrote: > In rte_mbuf.h, the description of the PKT_RX_VLAN flag (lines 93-94) says that > mbuf->vlan_tci contains the VLAN TCI if the flag is set; however, the > description of the vlan_tci field (line 513) says that the > PKT_RX_VLAN_STRIPPED flag must be set for it to be valid. > > Which one is it? And will someone please update the comments in rte_mbuf.h > accordingly.
Thanks for spotting this, I will send a patch to fix it. PKT_RX_VLAN means that mbuf->vlan_tci is valid. And PKT_RX_VLAN_STRIPPED implies that PKT_RX_VLAN is set too.