Re: [dpdk-dev] [PATCH v6 4/6] ethdev: adjust APIs removal error report

[Thomas Monjalon]

20/01/2018 20:04, Matan Azrad:
> Konstantin wrote in another thread:
> >+    RTE_ETH_VALID_PORTID_OR_ERR_RET(port_id, 0);
> >+
> >+    dev = &rte_eth_devices[port_id];
> >+
> >+    RTE_FUNC_PTR_OR_ERR_RET(*dev->dev_ops->is_removed, 0);
> 
> > I'd says these 2 checks have to be swapped.
> 
> Konstantin, Please explain why.

I think he was talking about these 2 tests:

+       RTE_FUNC_PTR_OR_ERR_RET(*dev->dev_ops->is_removed, 0);
+       if (dev->state == RTE_ETH_DEV_REMOVED)
+               return 1;