17/01/2018 23:09, Thomas Monjalon:
> 17/01/2018 22:57, Ferruh Yigit:
> > port_id is now 16bits, update function parameter according.
> >
> > Fixes: 4c270218aa26 ("ethdev: support security APIs")
> > Cc: sta...@dpdk.org
> > Cc: declan.dohe...@intel.com
> >
> > Signed-off-by: Ferruh Yigit <ferruh.yi...@intel.com>
> > Acked-by: Hemant Agrawal <hemant.agra...@nxp.com>
>
> Obviously,
> Acked-by: Thomas Monjalon <tho...@monjalon.net>
Not so obvious actually.
It is a good fix, but an API change.
This function was not declared experimental.
It must wait 18.05.
And the function has no doxygen!
And the function was placed randomly in the middle of struct declarations!
One more proof of the poor quality of rte_security stuff.
