While doing link status refactoring, I noticed that the eth_dev_link_update function return value is unused by common code (in rte_eth_dev_link_get); but is being expected by failsafe driver.
The return values are not consistent across drivers, and link update function is only valid if device is not using LSC. Therefore, the failsafe PMD should not be calling device internal functions directly and expecting a valid return value.