On Tuesday 16 January 2018 03:14 PM, Shreyansh Jain wrote:
On Thursday 11 January 2018 10:36 PM, Ferruh Yigit wrote:
From: Stephen Hemminger <step...@networkplumber.org>

Use new helper function to update the link status.
As a good side effect this fixes a but because this driver was not
                               ^^^^^^
                           needs rephrasing

returning correct status (should be -1 in link_status changed).

Signed-off-by: Stephen Hemminger <step...@networkplumber.org>
---
  drivers/net/dpaa2/dpaa2_ethdev.c | 65 +++++-----------------------------------
  1 file changed, 7 insertions(+), 58 deletions(-)

Other than the change in commit message highlighted above:

Acked-by: Shreyansh Jain <shreyansh.j...@nxp.com>

Thanks.


Also, I forgot to add in previous email, I am assuming _rte_eth_linkstatus_get would be rte_eth_linkstatus_get eventually.

I concur with your comments in [1] - it certainly would be better to have either @internal or _rte - and not both.

http://dpdk.org/ml/archives/dev/2018-January/086742.html

Reply via email to