-----Original Message-----
> Date: Mon, 15 Jan 2018 11:41:12 +0530
> From: Hemant Agrawal <hemant.agra...@nxp.com>
> To: dev@dpdk.org
> CC: jerin.ja...@caviumnetworks.com, olivier.m...@6wind.com,
> santosh.shu...@caviumnetworks.com
> Subject: [PATCH v2 3/5] mbuf: support register mempool Hw ops name APIs
> X-Mailer: git-send-email 2.7.4
>
> With this patch the specific HW mempool are no longer required to be
> specified in the config file at compile. A default platform hw mempool
> can be detected dynamically and published to config at run time.
> Only one type of HW mempool can be active default.
>
> Signed-off-by: Hemant Agrawal <hemant.agra...@nxp.com>
> ---
> lib/librte_mbuf/Makefile | 1 +
> lib/librte_mbuf/rte_mbuf.c | 42
> +++++++++++++++++++++++++++++++++---
> lib/librte_mbuf/rte_mbuf.h | 20 +++++++++++++++++
> lib/librte_mbuf/rte_mbuf_version.map | 8 +++++++
> 4 files changed, 68 insertions(+), 3 deletions(-)
>
> diff --git a/lib/librte_mbuf/Makefile b/lib/librte_mbuf/Makefile
> index 398f724..85c4f9e 100644
> --- a/lib/librte_mbuf/Makefile
> +++ b/lib/librte_mbuf/Makefile
> @@ -7,6 +7,7 @@ include $(RTE_SDK)/mk/rte.vars.mk
> LIB = librte_mbuf.a
>
> CFLAGS += $(WERROR_FLAGS) -I$(SRCDIR) -O3
> +CFLAGS += -I$(RTE_SDK)/lib/librte_eal/common
> LDLIBS += -lrte_eal -lrte_mempool
>
> EXPORT_MAP := rte_mbuf_version.map
> diff --git a/lib/librte_mbuf/rte_mbuf.c b/lib/librte_mbuf/rte_mbuf.c
> index c085c37..fd3b6f5 100644
> --- a/lib/librte_mbuf/rte_mbuf.c
> +++ b/lib/librte_mbuf/rte_mbuf.c
> @@ -58,6 +58,7 @@
> #include <rte_hexdump.h>
> #include <rte_errno.h>
> #include <rte_memcpy.h>
> +#include <eal_internal_cfg.h>
>
> /*
> * ctrlmbuf constructor, given as a callback function to
> @@ -148,6 +149,43 @@ rte_pktmbuf_init(struct rte_mempool *mp,
> m->next = NULL;
> }
>
> +int
> +rte_mbuf_register_platform_mempool_ops(const char *ops_name)
> +{
> + if (internal_config.plat_mbuf_pool_ops_name == NULL) {
> + internal_config.plat_mbuf_pool_ops_name = ops_name;
> + return 0;
> + }
> + RTE_LOG(ERR, MBUF,
> + "%s is already registered as platform mbuf pool ops\n",
> + internal_config.plat_mbuf_pool_ops_name);
> + return -EACCES;
> +}
> +
> +const char *
> +rte_mbuf_platform_mempool_ops(void)
> +{
> + return internal_config.plat_mbuf_pool_ops_name;
> +}
> +
> +/* Return mbuf pool ops name */
> +static const char *
> +rte_mbuf_best_mempool_ops(void)
> +{
> + /* User defined mempool ops takes the priority */
> + const char *best_ops = rte_eal_mbuf_default_mempool_ops();
> + if (best_ops)
> + return best_ops;
> +
> + /* Next choice is platform configured mempool ops */
> + best_ops = rte_mbuf_platform_mempool_ops();
> + if (best_ops)
> + return best_ops;
> +
> + /* Last choice is to use the compile time config pool */
> + return RTE_MBUF_DEFAULT_MEMPOOL_OPS;
> +}
The mempool ops selection makes sense to me.
We could add an "weight" based mempool ops selection in future here.
http://dpdk.org/dev/patchwork/patch/32245/
