On 1/8/2018 10:15 AM, De Lara Guarch, Pablo wrote:
-----Original Message-----
From: Nicolau, Radu
Sent: Tuesday, December 12, 2017 12:50 PM
To: dev@dpdk.org
Cc: Ananyev, Konstantin <konstantin.anan...@intel.com>; Yigit, Ferruh
<ferruh.yi...@intel.com>; Gonzalez Monroy, Sergio
<sergio.gonzalez.mon...@intel.com>; De Lara Guarch, Pablo
<pablo.de.lara.gua...@intel.com>; Doherty, Declan
<declan.dohe...@intel.com>; akhil.go...@nxp.com; Nicolau, Radu
<radu.nico...@intel.com>
Subject: [PATCH 2/3] net/ixgbe: implemented security session get size
Use "implement" in infinitive.
Signed-off-by: Radu Nicolau <radu.nico...@intel.com>
---
drivers/net/ixgbe/ixgbe_ipsec.c | 7 +++++++
1 file changed, 7 insertions(+)
diff --git a/drivers/net/ixgbe/ixgbe_ipsec.c
b/drivers/net/ixgbe/ixgbe_ipsec.c index 105da11..720d6a1 100644
--- a/drivers/net/ixgbe/ixgbe_ipsec.c
+++ b/drivers/net/ixgbe/ixgbe_ipsec.c
@@ -446,6 +446,12 @@ ixgbe_crypto_create_session(void *device, }
static int
+ixgbe_crypto_session_get_size(__rte_unused void *device) {
Do you think passing device to the function prototype is needed?
Are you expecting other drivers to use it?
I added for consistency with cryptodev.
Also, move the braces to a new line (both opening and ending).
They are correctly formatted on the patch itself.
+ return sizeof(struct ixgbe_crypto_session); }
+
Thanks,
Pablo
