> -----Original Message-----
> From: Zhang, Qi Z
> Sent: Sunday, January 14, 2018 12:02 PM
> To: Xing, Beilei <beilei.x...@intel.com>
> Cc: dev@dpdk.org; sta...@dpdk.org
> Subject: RE: [PATCH v2] net/i40e: fix packet type parser issue
>
>
>
> > -----Original Message-----
> > From: Xing, Beilei
> > Sent: Friday, January 12, 2018 4:42 PM
> > To: Zhang, Qi Z <qi.z.zh...@intel.com>
> > Cc: dev@dpdk.org; sta...@dpdk.org
> > Subject: [PATCH v2] net/i40e: fix packet type parser issue
> >
> > Ptype mapping table will fail to update when loading PPP profile, fix
> > the issue via modifying metadata and adding check.
> > This patch also adds parser for IPV4FRAG and IPV6FRAG.
> >
> > Fixes: ab2e350c4f4b ("net/i40e: improve packet type parser")
> > Cc: sta...@dpdk.org
> >
> > Signed-off-by: Beilei Xing <beilei.x...@intel.com>
> > ---
> >
> > v2 changes:
> > - Add parser for IPV4FRAG and IPV6FRAG.
> >
> > drivers/net/i40e/i40e_ethdev.c | 44
> > ++++++++++++++++++++++++++---------------
> > drivers/net/i40e/rte_pmd_i40e.c | 6 ++++--
> > 2 files changed, 32 insertions(+), 18 deletions(-)
> >
> > diff --git a/drivers/net/i40e/i40e_ethdev.c
> > b/drivers/net/i40e/i40e_ethdev.c index d80671a..69704e3 100644
> > --- a/drivers/net/i40e/i40e_ethdev.c
> > +++ b/drivers/net/i40e/i40e_ethdev.c
> > @@ -11283,43 +11283,55 @@ i40e_update_customized_ptype(struct
> > rte_eth_dev *dev, uint8_t *pkg,
> > continue;
> > memset(name, 0, sizeof(name));
> > strcpy(name, proto[n].name);
> > - if (!strncmp(name, "PPPOE", 5))
> > + if (!strncmp(name, "PPPoE", 5))
> > ptype_mapping[i].sw_ptype |=
> >
> RTE_PTYPE_L2_ETHER_PPPOE;
> > - else if (!strncmp(name, "OIPV4", 5)) {
> > + else if (!strncmp(name, "IPV4FRAG", 8) &&
> > + !in_tunnel) {
> > ptype_mapping[i].sw_ptype |=
> >
> RTE_PTYPE_L3_IPV4_EXT_UNKNOWN;
> > - in_tunnel = true;
> > - } else if (!strncmp(name, "IPV4", 4) &&
> > - !in_tunnel)
> > ptype_mapping[i].sw_ptype |=
> > -
> RTE_PTYPE_L3_IPV4_EXT_UNKNOWN;
> > - else if (!strncmp(name, "IPV4FRAG", 8) &&
> > - in_tunnel) {
> > + RTE_PTYPE_L4_FRAG;
> > + } else if (!strncmp(name, "IPV4FRAG", 8) &&
> > + in_tunnel) {
> > ptype_mapping[i].sw_ptype |=
> >
> RTE_PTYPE_INNER_L3_IPV4_EXT_UNKNOWN;
> > ptype_mapping[i].sw_ptype |=
> > RTE_PTYPE_INNER_L4_FRAG;
> > } else if (!strncmp(name, "IPV4", 4) &&
> > + !in_tunnel)
> > + ptype_mapping[i].sw_ptype |=
> > +
> RTE_PTYPE_L3_IPV4_EXT_UNKNOWN;
> > + else if (!strncmp(name, "OIPV4", 5)) {
> > + ptype_mapping[i].sw_ptype |=
> > +
> RTE_PTYPE_L3_IPV4_EXT_UNKNOWN;
> > + in_tunnel = true;
> > + } else if (!strncmp(name, "IPV4", 4) &&
> > in_tunnel)
> Since you are doing some reordering here, it's better to move IPV4 &&
> in_tunnel case above OIPV4, to match IPV4 && !in_tunnel case.
OK, will update in next version, thanks.
