Hi Anatoly, Thanks for your comments. Updated. Please review the version 2.
Thanks, Phil Yang > -----Original Message----- > From: Burakov, Anatoly [mailto:anatoly.bura...@intel.com] > Sent: Saturday, January 13, 2018 1:44 AM > To: Phil Yang <phil.y...@arm.com>; dev@dpdk.org > Cc: nd <n...@arm.com>; Jianbo Liu <jianbo....@arm.com>; Herbert Guan > <herbert.g...@arm.com> > Subject: Re: [dpdk-dev] [PATCH] test/memzone: Fix test_memzone_basic & > test_memzone_free issues. > > On 11-Jan-18 9:41 AM, Phil Yang wrote: > > 1. test_memzone_basic: No need to free a NULL memzone. It will cause > > test termination. > > 2. test_memzone_free: Out of mz[RTE_MAX_MEMZONE] memory bound > while > > reserving memzone for mz. It will flush variable i. Fix by extend to > > mz[RTE_MAX_MEMZONE + 1]. > > > > Signed-off-by: Phil Yang <phil.y...@arm.com> > > --- > > test/test/test_memzone.c | 6 +----- > > 1 file changed, 1 insertion(+), 5 deletions(-) > > > > diff --git a/test/test/test_memzone.c b/test/test/test_memzone.c index > > 6e80977..24e29a7 100644 > > --- a/test/test/test_memzone.c > > +++ b/test/test/test_memzone.c > > @@ -251,10 +251,6 @@ test_memzone_reserve_flags(void) > > printf("MEMZONE FLAG 2MB\n"); > > return -1; > > } > > - if (rte_memzone_free(mz)) { > > - printf("Fail memzone free\n"); > > - return -1; > > - } > > } > > > > if (hugepage_2MB_avail && hugepage_1GB_avail) { @@ -746,7 > +742,7 > > @@ test_memzone_bounded(void) > > static int > > test_memzone_free(void) > > { > > - const struct rte_memzone *mz[RTE_MAX_MEMZONE]; > > + const struct rte_memzone *mz[RTE_MAX_MEMZONE + 1]; > > int i; > > char name[20]; > > > > > > This should be split into two separate patches, as there are two different > issues > being addressed. Provided that's done, > > Acked-by: Anatoly Burakov <anatoly.bura...@intel.com> > > -- > Thanks, > Anatoly
