Thanks Marko,
Fix the issues according to your comments.
V2 has been sent out.
Thanks
Zhiyong
> -----Original Message-----
> From: Kovacevic, Marko
> Sent: Friday, January 12, 2018 5:37 PM
> To: Yang, Zhiyong <zhiyong.y...@intel.com>; dev@dpdk.org
> Cc: Mcnamara, John <john.mcnam...@intel.com>
> Subject: RE: [dpdk-dev] [PATCH] doc: fix link bonding pmd typo in prog guide
>
> > fix one typo and a grammatical mistake.
> >
> > Fixes: b0152b1b40fe("doc: update bonding")
> > Signed-off-by: Zhiyong Yang <zhiyong.y...@intel.com>
>
> First thing the git check log spit this error out so can you please just make
> these changes
>
> Running git check log on HEAD~1: 32787
> ======================================
> Wrong headline lowercase:
> doc: fix link bonding pmd typo in prog guide Wrong tag:
> ^^^^
> Upper case PMD
>
> Fixes: b0152b1b40fe("doc: update bonding") Wrong 'Fixes' reference:
> Fixes: b0152b1b40fe("doc: update bonding")
> ^^
> Insert a space..... Fixes: b0152b1b40fe ("doc: update bonding")
>
> Is it candidate for Cc: sta...@dpdk.org backport?
> If it is Cc: the stable mailing list in the commit message body
>
> I don't think this is really an error but put a space between Fixes And
> Signed -
> off-by
>
> > Fixes: b0152b1b40fe("doc: update bonding")
> > Signed-off-by: Zhiyong Yang <zhiyong.y...@intel.com>
>
>
> <...>
>
> >
> > The Link Bonding PMD library(librte_pmd_bond) supports bonding of
> > groups of ``rte_eth_dev`` ports of the same speed and duplex to
> > provide -similar the capabilities to that found in Linux bonding
> > driver to allow the
> ^^^^^^^^^^^^^^^^^^^^^^^^^^
> "to provide the similar capabilities" sounds better to me
>
> > +the capabilities similar to that found in Linux bonding driver to
> > +allow the
> > aggregation of multiple (slave) NICs into a single logical interface
> > between a server and a switch. The new bonded PMD will then process
> > these interfaces based on the mode of operation specified to provide
> > support for features such
>
> Once this has been changed you can include my Ack in the next version of
> the patch.
>
> Acked-by: Marko Kovacevic <marko.kovace...@intel.com>
