Tested-by: Peng Yuan<yuan.p...@intel.com>
- Tested Branch: master
- Tested commit 6c7001480ac6356ff0a4995f3ed495ed9c866061
- OS: 4.5.5-300.fc24.x86_64
- GCC: gcc version 5.3.1 20151207 (Red Hat 5.3.1-2) (GCC)
- CPU: Intel(R) Xeon(R) CPU E5-2699 v4 @ 2.20GHz
- NIC: Intel Corporation Device Fortville [8086:1572]
- Default x86_64-native-linuxapp-gcc configuration
- Prerequisites:
- Total 1 cases, 1 passed, 0 failed
- Case:
./usertools/dpdk-devbind.py -b igb_uio 05:00:0 echo 1
>/sys/bus/pci/devices/0000:05:00.0/max_vfs
./usertools/dpdk-devbind.py -b vfio-pci 05:02.0
pf:
./x86_64-native-linuxapp-gcc/app/testpmd -c f -n 4 -w
05:00.0,queue-num-per-vf=4 --file-prefix=test1 --socket-mem 1024,1024 - -I
vf:
./x86_64-native-linuxapp-gcc/app/testpmd -c f -n 4 -w 05:02.0
--file-prefix=test2 --socket-mem 1024,1024 - -i --rxq=4 --txq=4
EAL: Detected 88 lcore(s)
EAL: Probing VFIO support...
EAL: VFIO support initialized
EAL: PCI device 0000:05:02.0 on NUMA socket 0
EAL: probe driver: 8086:154c net_i40e_vf
EAL: using IOMMU type 1 (Type 1)
Interactive-mode selected
USER1: create a new mbuf pool <mbuf_pool_socket_0>: n=171456, size=2176,
socket=0
USER1: create a new mbuf pool <mbuf_pool_socket_1>: n=171456, size=2176,
socket=1 Configuring Port 0 (socket 0) Port 0: 7E:AC:58:44:3C:94 Checking
link statuses...
Done
testpmd> port stop all
Stopping ports...
Checking link statuses...
Done
testpmd> port config all txq 5
Fail: input txq (5) can't be greater than max_tx_queues (4) of port 0
testpmd> port config all rxq 5
Fail: input rxq (5) can't be greater than max_rx_queues (4) of port 0
testpmd> port start all Port 0: 5A:19:E4:5C:A3:C7 Checking link statuses...
Done
testpmd> show port info all
Current number of RX queues: 4
Max possible RX queues: 4
Current number of TX queues: 4
Max possible TX queues: 4
there is no core dump, and the actual queue number doesn't change.
The case passed.
-----Original Message-----
From: Dai, Wei
Sent: Friday, January 12, 2018 4:10 PM
To: Peng, Yuan <yuan.p...@intel.com>; Ananyev, Konstantin
<konstantin.anan...@intel.com>; Lu, Wenzhuo <wenzhuo...@intel.com>; Xing,
Beilei <beilei.x...@intel.com>
Cc: dev@dpdk.org; Dai, Wei <wei....@intel.com>; sta...@dpdk.org
Subject: [PATCH v5 1/2] app/testpmd: fix invalid rxq number setting
If an invalid number of RX queues is configured from testpmd run-time command
like "port config all rxq number" or from --rxq in the command to start
testpmd, the global variable nb_rxq is updated by this invalid value without
this patch. It may cause testpmd crash. This patch refuses invalid rxq setting
and keeps its last correct value.
Fixes: ce8d561418d4 ("app/testpmd: add port configuration settings")
Cc: sta...@dpdk.org
Signed-off-by: Wei Dai <wei....@intel.com>
Acked-by: Konstantin Ananyev <konstantin.anan...@intel.com>
---
app/test-pmd/cmdline.c | 2 ++
app/test-pmd/parameters.c | 7 ++++---
app/test-pmd/testpmd.c | 46 ++++++++++++++++++++++++++++++++++++++++++++++
app/test-pmd/testpmd.h | 3 +++
4 files changed, 55 insertions(+), 3 deletions(-)
diff --git a/app/test-pmd/cmdline.c b/app/test-pmd/cmdline.c index
5b2e2ef..f0623b1 100644
--- a/app/test-pmd/cmdline.c
+++ b/app/test-pmd/cmdline.c
@@ -1518,6 +1518,8 @@ cmd_config_rx_tx_parsed(void *parsed_result,
printf("Warning: Either rx or tx queues should be non
zero\n");
return;
}
+ if (check_nb_rxq(res->value) != 0)
+ return;
nb_rxq = res->value;
}
else if (!strcmp(res->name, "txq")) {
diff --git a/app/test-pmd/parameters.c b/app/test-pmd/parameters.c index
304b98d..c46e734 100644
--- a/app/test-pmd/parameters.c
+++ b/app/test-pmd/parameters.c
@@ -536,6 +536,7 @@ launch_args_parse(int argc, char** argv)
int n, opt;
char **argvopt;
int opt_idx;
+ portid_t pid;
enum { TX, RX };
static struct option lgopts[] = {
@@ -922,12 +923,12 @@ launch_args_parse(int argc, char** argv)
rss_hf = ETH_RSS_UDP;
if (!strcmp(lgopts[opt_idx].name, "rxq")) {
n = atoi(optarg);
- if (n >= 0 && n <= (int) MAX_QUEUE_ID)
+ if (n >= 0 && check_nb_rxq((queueid_t)n) == 0)
nb_rxq = (queueid_t) n;
else
rte_exit(EXIT_FAILURE, "rxq %d invalid
- must be"
- " >= 0 && <= %d\n", n,
- (int) MAX_QUEUE_ID);
+ " >= 0 && <= %u\n", n,
+ get_allowed_max_nb_rxq(&pid));
}
if (!strcmp(lgopts[opt_idx].name, "txq")) {
n = atoi(optarg);
diff --git a/app/test-pmd/testpmd.c b/app/test-pmd/testpmd.c index
9414d0e..4e8667d 100644
--- a/app/test-pmd/testpmd.c
+++ b/app/test-pmd/testpmd.c
@@ -540,6 +540,52 @@ check_socket_id(const unsigned int socket_id)
return 0;
}
+/*
+ * Get the allowed maximum number of RX queues.
+ * *pid return the port id which has minimal value of
+ * max_rx_queues in all ports.
+ */
+queueid_t
+get_allowed_max_nb_rxq(portid_t *pid)
+{
+ queueid_t allowed_max_rxq = MAX_QUEUE_ID;
+ portid_t pi;
+ struct rte_eth_dev_info dev_info;
+
+ RTE_ETH_FOREACH_DEV(pi) {
+ rte_eth_dev_info_get(pi, &dev_info);
+ if (dev_info.max_rx_queues < allowed_max_rxq) {
+ allowed_max_rxq = dev_info.max_rx_queues;
+ *pid = pi;
+ }
+ }
+ return allowed_max_rxq;
+}
+
+/*
+ * Check input rxq is valid or not.
+ * If input rxq is not greater than any of maximum number
+ * of RX queues of all ports, it is valid.
+ * if valid, return 0, else return -1
+ */
+int
+check_nb_rxq(queueid_t rxq)
+{
+ queueid_t allowed_max_rxq;
+ portid_t pid = 0;
+
+ allowed_max_rxq = get_allowed_max_nb_rxq(&pid);
+ if (rxq > allowed_max_rxq) {
+ printf("Fail: input rxq (%u) can't be greater "
+ "than max_rx_queues (%u) of port %u\n",
+ rxq,
+ allowed_max_rxq,
+ pid);
+ return -1;
+ }
+ return 0;
+}
+
static void
init_config(void)
{
diff --git a/app/test-pmd/testpmd.h b/app/test-pmd/testpmd.h index
2a266fd..e815509 100644
--- a/app/test-pmd/testpmd.h
+++ b/app/test-pmd/testpmd.h
@@ -700,6 +700,9 @@ enum print_warning { int port_id_is_invalid(portid_t
port_id, enum print_warning warning); int new_socket_id(unsigned int
socket_id);
+queueid_t get_allowed_max_nb_rxq(portid_t *pid); int
+check_nb_rxq(queueid_t rxq);
+
/*
* Work-around of a compilation error with ICC on invocations of the
* rte_be_to_cpu_16() function.
--
2.7.5
