On Wed, Jan 10, 2018 at 06:21:01PM -0600, Erik Gabriel Carrillo wrote:
> Signed-off-by: Erik Gabriel Carrillo <erik.g.carri...@intel.com>
> ---
> lib/librte_eventdev/rte_event_timer_adapter.c | 11 +----------
> lib/librte_eventdev/rte_event_timer_adapter.h | 2 --
> 2 files changed, 1 insertion(+), 12 deletions(-)
>
> diff --git a/lib/librte_eventdev/rte_event_timer_adapter.c
> b/lib/librte_eventdev/rte_event_timer_adapter.c
> index 68748be..a4c8012 100644
> --- a/lib/librte_eventdev/rte_event_timer_adapter.c
> +++ b/lib/librte_eventdev/rte_event_timer_adapter.c
> @@ -609,15 +609,6 @@ sw_event_timer_adapter_stop(const struct
> rte_event_timer_adapter *adapter)
> return rte_service_component_runstate_set(sw_data->service_id, 0);
> }
>
> -static void
> -sw_event_timer_adapter_get_info(const struct rte_event_timer_adapter
> *adapter,
> - struct rte_event_timer_adapter_info *adapter_info)
> -{
> - struct rte_event_timer_adapter_sw_data *sw_data;
> - sw_data = adapter->data->adapter_priv;
> - adapter_info->service_id = sw_data->service_id;
> -}
> -
Removing get_info is not a good idea, the application using event timer might
need some info about capabilities.
Thinking form sw_event_timer perspective I think we need to have a caps to check
if it supports DISTRIBUTED scheduling similar to sw event dev (or) expose
RTE_EVENT_TIMER_ADAPTER_CAP_INTERNAL_PORT.
> static int
> sw_event_timer_arm_burst(const struct rte_event_timer_adapter *adapter,
> struct rte_event_timer **evtims,
> @@ -661,7 +652,7 @@ const struct rte_event_timer_adapter_ops
> sw_event_adapter_timer_ops = {
> .uninit = sw_event_timer_adapter_uninit,
> .start = sw_event_timer_adapter_start,
> .stop = sw_event_timer_adapter_stop,
> - .get_info = sw_event_timer_adapter_get_info,
> + .get_info = NULL,
> .arm_burst = sw_event_timer_arm_burst,
> .arm_tmo_tick_burst = sw_event_timer_arm_tmo_tick_burst,
> .cancel_burst = sw_event_timer_cancel_burst,
> diff --git a/lib/librte_eventdev/rte_event_timer_adapter.h
> b/lib/librte_eventdev/rte_event_timer_adapter.h
> index 84d3c39..8d29cfc 100644
> --- a/lib/librte_eventdev/rte_event_timer_adapter.h
> +++ b/lib/librte_eventdev/rte_event_timer_adapter.h
> @@ -283,8 +283,6 @@ struct rte_event_timer_adapter_info {
> /**< Event timer adapter capabilities */
> int16_t event_dev_port_id;
> /**< Event device port ID, if applicable */
> - int32_t service_id;
> - /**< Service ID, if applicable */
> };
>
> /**
> --
> 2.6.4
>
