Hi Wenzhuo, Thanks for your suggestion, will update later.
Regards, Xueming > -----Original Message----- > From: Lu, Wenzhuo [mailto:wenzhuo...@intel.com] > Sent: Wednesday, January 10, 2018 8:26 PM > To: Xueming(Steven) Li <xuemi...@mellanox.com> > Cc: Wu, Jingjing <jingjing...@intel.com>; dev@dpdk.org; Olivier MATZ > <olivier.m...@6wind.com>; Burakov, Anatoly <anatoly.bura...@intel.com> > Subject: RE: [dpdk-dev] [PATCH v1] app/testpmd: support command echo in > CLI batch loading > > Hi Xueming, > > > -----Original Message----- > > From: Xueming(Steven) Li [mailto:xuemi...@mellanox.com] > > Sent: Wednesday, January 10, 2018 4:52 PM > > To: Lu, Wenzhuo <wenzhuo...@intel.com> > > Cc: Wu, Jingjing <jingjing...@intel.com>; dev@dpdk.org; Olivier MATZ > > <olivier.m...@6wind.com>; Burakov, Anatoly <anatoly.bura...@intel.com> > > Subject: RE: [dpdk-dev] [PATCH v1] app/testpmd: support command echo > > in CLI batch loading > > > > > > > -----Original Message----- > > > From: Lu, Wenzhuo [mailto:wenzhuo...@intel.com] > > > Sent: Wednesday, January 10, 2018 4:36 PM > > > To: Xueming(Steven) Li <xuemi...@mellanox.com> > > > Cc: Wu, Jingjing <jingjing...@intel.com>; dev@dpdk.org; Olivier MATZ > > > <olivier.m...@6wind.com>; Burakov, Anatoly > > > <anatoly.bura...@intel.com> > > > Subject: RE: [dpdk-dev] [PATCH v1] app/testpmd: support command echo > > > in CLI batch loading > > > > > > Hi Xueming, > > > > > > > -----Original Message----- > > > > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Xueming Li > > > > Sent: Tuesday, December 26, 2017 10:26 PM > > > > Cc: Xueming Li <xuemi...@mellanox.com>; Wu, Jingjing > > > > <jingjing...@intel.com>; dev@dpdk.org; Olivier MATZ > > > > <olivier.m...@6wind.com>; Burakov, Anatoly > > > > <anatoly.bura...@intel.com> > > > > Subject: [dpdk-dev] [PATCH v1] app/testpmd: support command echo > > > > in CLI batch loading > > > > > > > > Use first bit of verbose_level to enable CLI echo of batch loading. > > > After this patch, the first bit of verbose_level is ambiguous. It > > > can still enable/disable the log print. > > > Is it by design? > > You are correct, there are some code in testpmd simply testing verbose>0. > > How about changing all the test to: verbose & 1? I have another > > patchset using other bits of verbose... > I don't object to give more meaning to verbose. Agree with "verbose & 1". > As you said, now only 0 and 1 has meaning. > Don't forget to comment this variable carefully. And also update the doc > 'testpmd_funcs.rst' to let the users know how to use the new functions of > this CLI 'set verbose (level)'.
