> -----Original Message----- > From: Thomas Monjalon [mailto:tho...@monjalon.net] > Sent: Wednesday, January 10, 2018 8:09 AM > To: Hu, Jiayu <jiayu...@intel.com> > Cc: dev@dpdk.org; Richardson, Bruce <bruce.richard...@intel.com>; Chen, > Junjie J <junjie.j.c...@intel.com>; Tan, Jianfeng <jianfeng....@intel.com>; > step...@networkplumber.org; Yigit, Ferruh <ferruh.yi...@intel.com>; > Ananyev, Konstantin <konstantin.anan...@intel.com>; Yao, Lei A > <lei.a....@intel.com> > Subject: Re: [dpdk-dev] [PATCH v4 1/2] gro: code cleanup > > Hi, > > 05/01/2018 07:12, Jiayu Hu: > > - Remove needless check and variants > > - For better understanding, update the programmer guide and rename > > internal functions and variants > > - For supporting tunneled gro, move common internal functions from > > gro_tcp4.c to gro_tcp4.h > > - Comply RFC 6864 to process the IPv4 ID field > > I think you could split this patch in several ones. > Please remind that the git history can be used later to understand > why the changes were done.
Thanks for your suggestion. I will split this patch into three patches: code cleanup, comply RFC 6864 to process IPv4 ID field and extract common functions for supporting tunneled GRO. Regards, Jiayu > > Thanks
