Yuanhan, > -----Original Message----- > From: Yuanhan Liu [mailto:y...@fridaylinux.org] > Sent: Tuesday, January 9, 2018 9:24 PM > To: Yang, Zhiyong <zhiyong.y...@intel.com> > Cc: dev@dpdk.org; sta...@dpdk.org > Subject: Re: [dpdk-dev] [PATCH] examples/vhost: fix extend MAX_QUEUES > to resolve startup failure > > On Thu, Jan 04, 2018 at 02:33:32PM +0800, Zhiyong Yang wrote: > > When binding X710 NIC (i40e driver) to DPDK, vhost sample startups > > failure. > > The sample requires that MAX_QUEUES should be defined no less than 320. > > So, the patch redefines MAX_QUEUES 320 to fix the issue. > > It just makes the issue disappear. It doesn't really fix the issue. > And I belive we have tried to fix this kind of issues in this way many times. > (just check the git history). As you known, none of them really worked. You > just added one more try, which is very likely will be broken again when Intel > has one more new NIC. > > The error comes from: > > if (dev_info.max_rx_queues > MAX_QUEUES) { > rte_exit(EXIT_FAILURE, > "please define MAX_QUEUES no less than %u in %s\n", > dev_info.max_rx_queues, __FILE__); > } > > I think such check is overkill and we don't really need that. Could you just > remove such check and do some validations on few difference nics? >
Agreed, Such check doesn't help anything, Let me send V2 to remove it if nothing can be affected. Thanks Zhiyong > Thanks. > > --yliu
