On 12/23/2017 12:52 AM, Amr Mokhtar wrote: > - wireless baseband device (bbdev) library files > - bbdev is tagged as EXPERIMENTAL > - makefiles and configuration macros definition > - bbdev library is enabled by default > - release notes of the initial version
Hi Amr, Overall lgtm: Acked-by: Ferruh Yigit <ferruh.yi...@intel.com> There are a few minor things commented below, can you please check them? You can keep my ack with next version. ./devtools/check-git-log.sh complaining about patch title, same with some of the other patches, can you please update them? > > Signed-off-by: Amr Mokhtar <amr.mokh...@intel.com> <...> > @@ -593,6 +593,13 @@ CONFIG_RTE_LIBRTE_PMD_SW_EVENTDEV_DEBUG=n > CONFIG_RTE_LIBRTE_PMD_OCTEONTX_SSOVF=y > CONFIG_RTE_LIBRTE_PMD_OCTEONTX_SSOVF_DEBUG=n > > +# Compile generic wireless base band device library > +# EXPERIMENTAL: API may change without prior notice > +# > +CONFIG_RTE_LIBRTE_BBDEV=y > +CONFIG_RTE_LIBRTE_BBDEV_DEBUG=n It seems this option is not used now. <...> > @@ -0,0 +1,586 @@ > +.. > + SPDX-License-Identifier: BSD-3-Clause > + Copyright(c) 2017 Intel Corporation Minor issue but can you please move SPDX to first line, same for a few more documents. <...> > +/* Find data alocated for the device or if not found return first unused > bbdev > + * data. If all structures are in use and none is used by the device return > + * NULL. > + */ If this kind of comment syntax because of checkpatch warning you can ignore it, fyi. <...>
