On Sun, Dec 31, 2017 at 05:32:02AM +0530, Pavan Nikhilesh wrote:
> Add Cavium octeontx to meson build and change order of drivers built
> from event->mempool->net to mempool->net->event to resolve dependency.
>
> Signed-off-by: Pavan Nikhilesh <pbhagavat...@caviumnetworks.com>
> ---
> drivers/event/meson.build | 2 +-
> drivers/event/octeontx/meson.build | 5
> +++++
> ...octeontx_ssovf_version.map => rte_pmd_octeontx_event_version.map} | 0
> drivers/meson.build | 2 +-
> 4 files changed, 7 insertions(+), 2 deletions(-)
> create mode 100644 drivers/event/octeontx/meson.build
> rename drivers/event/octeontx/{rte_pmd_octeontx_ssovf_version.map =>
> rte_pmd_octeontx_event_version.map} (100%)
>
> diff --git a/drivers/event/meson.build b/drivers/event/meson.build
> index 437d80bfd..d7bc48545 100644
> --- a/drivers/event/meson.build
> +++ b/drivers/event/meson.build
> @@ -1,7 +1,7 @@
> # SPDX-License-Identifier: BSD-3-Clause
> # Copyright(c) 2017 Intel Corporation
>
> -drivers = ['skeleton', 'sw']
> +drivers = ['skeleton', 'sw', 'octeontx']
> std_deps = ['eventdev', 'kvargs']
> config_flag_fmt = 'RTE_LIBRTE_@0@_EVENTDEV_PMD'
> driver_name_fmt = 'rte_pmd_@0@_event'
> diff --git a/drivers/event/octeontx/meson.build
> b/drivers/event/octeontx/meson.build
> new file mode 100644
> index 000000000..fa46a67b5
> --- /dev/null
> +++ b/drivers/event/octeontx/meson.build
> @@ -0,0 +1,5 @@
> +sources = files('ssovf_evdev.c',
> + 'ssovf_worker.c'
> +)
> +
> +deps += ['mempool_octeontx', 'bus_vdev', 'pmd_octeontx']
> diff --git a/drivers/event/octeontx/rte_pmd_octeontx_ssovf_version.map
> b/drivers/event/octeontx/rte_pmd_octeontx_event_version.map
> similarity index 100%
> rename from drivers/event/octeontx/rte_pmd_octeontx_ssovf_version.map
> rename to drivers/event/octeontx/rte_pmd_octeontx_event_version.map
> diff --git a/drivers/meson.build b/drivers/meson.build
> index f5009aa2e..52d7176a3 100644
> --- a/drivers/meson.build
> +++ b/drivers/meson.build
> @@ -1,7 +1,7 @@
> # SPDX-License-Identifier: BSD-3-Clause
> # Copyright(c) 2017 Intel Corporation
>
> -driver_classes = ['bus', 'crypto', 'event', 'mempool', 'net']
> +driver_classes = ['bus', 'crypto', 'mempool', 'net', 'event']
This change is ok with me, but I think you need to add an explicit
comment in the file - not just in the comment message - as to why the
order is not alphabetical.
In fact, it might be good to split out each type on it's own line with a
comment, since bus should almost certainly go first, then probably
mempool - since we might have crypto drivers in future that depend on
it, and then finally the other types.
>
> foreach class:driver_classes
> drivers = []
> --
> 2.15.1
>
