On Fri, Dec 22, 2017 at 10:46:34AM +0530, Shreyansh Jain wrote: > Hi Bruce, > > some trivial comments inline... > > On Thursday 21 December 2017 09:42 PM, Bruce Richardson wrote: > > Add a document describing how to configure, build and install DPDK using > > meson and ninja. Document includes references to official installation docs > > using make, and points out the experimental nature of the build. > > > > Signed-off-by: Bruce Richardson <bruce.richard...@intel.com> > > --- > > INSTALL.meson | 177 > > ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ > > Just out of curiosity, why not make it a rst file, as part of standard DPDK > documentation? Or, maybe until meson is experimental this readme can suffice > - but, we should have rst eventually - isn't it. >
Eventually this should be merged into the GSG doc, once it's more complete and less experimental. However, for V2, I will move this doc into the "doc/" subdirectory where there is a "build-sdk-quick.txt" doc, and rename this as "build-sdk-meson.txt". As for the other comments, they will be fixed in V2. Thanks for the good review. /Bruce
