On Wed, 3 Jan 2018 08:35:23 +0100 Nelio Laranjeiro <nelio.laranje...@6wind.com> wrote:
> Hi Stephen, > > On Tue, Jan 02, 2018 at 12:53:09PM -0800, Stephen Hemminger wrote: > > Since wait_to_complete is unused, don't pass it to helper functions. > > Use the standard RTE macro to indicate this is an unused parameter. > > I would suggest to use the (void) as it is done in the whole driver, a > specific patch should be done to use the rte_unused macro in all the > sources at once. > > Thanks, > There is a standard in DPDK using RTE macros. The whole driver should follow that rather than trying to be different.