On Wed, Jan 03, 2018 at 02:43:59PM +0100, Olivier Matz wrote: > I've walked through the PMDs as suggested by Andrew, and there was > indeed some conflicts with the initial patch. I've just submitted the > patch for vmxnet3 [1] and bnxt [2]. > > But there is still an issue with the qede driver, that overwrites the > MAC address in dev->data by the previous one if it cannot be set. It > seems it's the only driver that does this in error case, but anyway, > this behavior will be broken by the initial patch. > > So I submitted a v2 that only changes the behavior for i40evf [3]. > > I propose to include these 3 patches for 18.02, and announce an ABI > change for 18.05 to add a return value to dev_ops->mac_addr_set() and > move the ether_addr_copy() after the callback, only in case of success. > > Any opinions? > > > [1] https://dpdk.org/dev/patchwork/patch/32855/ > [2] https://dpdk.org/dev/patchwork/patch/32855/ > [3] https://dpdk.org/dev/patchwork/patch/32855/
Sorry: [1] https://dpdk.org/dev/patchwork/patch/32855/ [2] https://dpdk.org/dev/patchwork/patch/32856/ [3] https://dpdk.org/dev/patchwork/patch/32857/
