29/12/2017 08:55, Zhiyong Yang: > For virtio legacy device, testpmd startup fails when using > uio_pci_generic. The issue is caused by invoking the function > pci_ioport_map. The right intr_handle.type is already set before > calling it, we should avoid overwriting the default value "RTE_ > INTR_HANDLE_UNKNOWN" in it. Besides, the removal has no harm to > other cases since it already is set to this value (0) at init.
To be more precise, it is set to 0 by a memset on the whole struct during allocation in the scan function (pci_scan_one). > --- a/drivers/bus/pci/linux/pci.c > +++ b/drivers/bus/pci/linux/pci.c > @@ -723,7 +723,6 @@ pci_ioport_map(struct rte_pci_device *dev, int bar > __rte_unused, > if (!found) > return -1; > > - dev->intr_handle.type = RTE_INTR_HANDLE_UNKNOWN; There is the same assignment in pci_vfio_map_resource_primary(), pci_vfio_map_resource_secondary() and pci_uio_map_resource(). Please could you check why there is such assignments?
