The trigger for PMD to use the application RSS configuration should be based on the validity of rss_key and not the rss_key_len. Otherwise segmentation fault can occur if application provide valid RSS key length but without any RSS key.
Fixes: 29c1d8bb3e79 ("net/mlx5: handle a single RSS hash key for all protocols") Cc: nelio.laranje...@6wind.com Cc: sta...@dpdk.org Signed-off-by: Shahaf Shuler <shah...@mellanox.com> Acked-by: Yongseok Koh <ys...@mellanox.com> --- drivers/net/mlx5/mlx5_ethdev.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/mlx5/mlx5_ethdev.c b/drivers/net/mlx5/mlx5_ethdev.c index ca9ad0fef..282ef241e 100644 --- a/drivers/net/mlx5/mlx5_ethdev.c +++ b/drivers/net/mlx5/mlx5_ethdev.c @@ -550,7 +550,7 @@ dev_configure(struct rte_eth_dev *dev) unsigned int j; unsigned int reta_idx_n; const uint8_t use_app_rss_key = - !!dev->data->dev_conf.rx_adv_conf.rss_conf.rss_key_len; + !!dev->data->dev_conf.rx_adv_conf.rss_conf.rss_key; if (use_app_rss_key && (dev->data->dev_conf.rx_adv_conf.rss_conf.rss_key_len != -- 2.12.0