> -----Original Message----- > From: Zhao1, Wei > Sent: Friday, December 22, 2017 1:11 PM > To: dev@dpdk.org > Cc: Zhang, Qi Z <qi.z.zh...@intel.com>; Zhao1, Wei <wei.zh...@intel.com> > Subject: [PATCH v2] net/i40e: add fdir nvgre parameters check > > Add mask parameters check in nvgre parser for flow API. > > Fixes: 30965ca341278 ("net/i40e: add NVGRE flow parsing") > > Signed-off-by: Wei Zhao <wei.zh...@intel.com> > > --- > > V2: > -change c_k_s_rsvd0_ver mask check to 0xFFFF. > --- > drivers/net/i40e/i40e_flow.c | 35 +++++++++++++++++++++++++++++++++++ > 1 file changed, 35 insertions(+) > > diff --git a/drivers/net/i40e/i40e_flow.c b/drivers/net/i40e/i40e_flow.c index > 7e4936e..fa2e168 100644 > --- a/drivers/net/i40e/i40e_flow.c > +++ b/drivers/net/i40e/i40e_flow.c > @@ -3610,6 +3610,41 @@ i40e_flow_parse_nvgre_pattern(__rte_unused > struct rte_eth_dev *dev, > "Invalid TNI mask"); > return -rte_errno; > } > + if (nvgre_mask->protocol && > + nvgre_mask->protocol != 0xFFFF) { > + rte_flow_error_set(error, EINVAL, > + RTE_FLOW_ERROR_TYPE_ITEM, > + item, > + "Invalid NVGRE item"); > + return -rte_errno; > + } > + if (nvgre_mask->c_k_s_rsvd0_ver && > + nvgre_mask->c_k_s_rsvd0_ver != > + rte_cpu_to_be_16(0xFFFF)) { > + rte_flow_error_set(error, EINVAL, > + RTE_FLOW_ERROR_TYPE_ITEM, > + item, > + "Invalid NVGRE item"); > + return -rte_errno; > + } > + if (nvgre_spec->c_k_s_rsvd0_ver != > + rte_cpu_to_be_16(0x2000) && > + nvgre_mask->c_k_s_rsvd0_ver) { > + rte_flow_error_set(error, EINVAL, > + RTE_FLOW_ERROR_TYPE_ITEM, > + item, > + "Invalid NVGRE item"); > + return -rte_errno; > + } > + if (nvgre_mask->protocol && > + nvgre_spec->protocol != > + rte_cpu_to_be_16(0x6558)) { > + rte_flow_error_set(error, EINVAL, > + RTE_FLOW_ERROR_TYPE_ITEM, > + item, > + "Invalid NVGRE item"); > + return -rte_errno; > + } > rte_memcpy(((uint8_t *)&tenant_id_be + 1), > nvgre_spec->tni, 3); > filter->tenant_id = > -- > 2.9.3
Acked-by: Qi Zhang <qi.z.zh...@intel.com>