Wednesday, December 13, 2017 7:32 PM, Jerin Jacob: > > OK. I just suggested because adding the flag in PMD is harmless and we can > avoid an extra check(setting the DEV_TX_OFFLOAD_MBUF_FAST_FREE only > when PMD supports it) in application to hide warning as you pointed out. > No strong opinion on the specifics, I am just cared only reaching the flag to > driver.
Following some other comments from different examples I believe the way to go is the following: 1. application will set the offloads it *must have* in order to properly function. PMD will fail the configuration if not supported. Such kind of offloads are basically all the offloads besides DEV_TX_OFFLOAD_MBUF_FAST_FREE as it is an optimization. 2. application will set optional features only if supported (such as DEV_TX_OFFLOAD_MBUF_FAST_FREE) 3. I will remove the redundant print for offloads set but not supported. This can be done in the PMD level based on its implemented (as I understood some PMDs don't set some offloads but do expect to have them enabled. This though should be fixed IMO). > >
