> From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Kevin Laatz > Sent: Tuesday, December 19, 2017 5:32 PM > To: dev@dpdk.org > Cc: Richardson, Bruce <bruce.richard...@intel.com>; Laatz, Kevin > <kevin.la...@intel.com> > Subject: [dpdk-dev] [PATCH] meson: add tests to build > > This commit adds most of the remaining tests to the meson build. > They can be run using test binary as normal.
Cool, thanks for adding more tests! > Signed-off-by: Kevin Laatz <kevin.la...@intel.com> > --- > test/test/meson.build | 17 +++++++++++++++++ > 1 file changed, 17 insertions(+) > > diff --git a/test/test/meson.build b/test/test/meson.build > index 1a4f894..a9bc2f6 100644 > --- a/test/test/meson.build > +++ b/test/test/meson.build > @@ -47,6 +47,8 @@ test_sources = files('commands.c', > 'test_common.c', > 'test_cpuflags.c', > 'test_crc.c', > + 'test_cryptodev.c', > + 'test_cryptodev_blockcipher.c', Each of the test files here exports a number of actual test cases, eg: RTE>> cryptodev_null_autotest and similar. These test cases should be added to the list called "test_names" in the same file - so Meson knows about the tests. There was talk of refactoring away this list totally - and that would be good - but for now we're best to keep it in sync with the available tests. Apart from the above, the patch looks good to me! Will Review/Ack a v2. <snip>