On 12/18/2017 10:38 PM, Stephen Hemminger wrote: > This patch set implements dynamic logging for 11 drivers. > All these patches are compile tested only. I don't have > access to most of this hardware. > > It makes more sense to "just do it" for dynamic logging rather > than keeping TODO lists in the documentation and expecting the > vendors to fix their own code. The advantage of common repository > is that global changes can be done.
Hi Stephen, Thank you for the update, there a few minor comments in relevant patches, except from them set lgtm. Overall do you think keeping todo list is a bad idea? There are a few more issues like this and I am not sure how to communicate them with PMD maintainers, any suggestion is welcome. > > Stephen Hemminger (11): > avp: implement dynamic logging > bnx2x: implement dynamic logging > vmxnet3: implement dynamic logging > ixgbe: implement dynamic logging > e1000: implement dynamic logging > virtio: implement dynamic logging > nfp: implement dynamic logging > fm10k: implement dynamic logging > ena: implement dynamic logging > qede: implement dynamic logging > lio: implement dynamic logging <...>
