Hi Harry, Thanks for review and comments. Feedback inline.
On Tue, Dec 19, 2017 at 12:00:02PM +0000, Van Haaren, Harry wrote: > > From: Pavan Nikhilesh [mailto:pbhagavat...@caviumnetworks.com] > > Sent: Thursday, December 7, 2017 8:37 PM > > To: Eads, Gage <gage.e...@intel.com>; jerin.jacobkollanukka...@cavium.com; > > Van Haaren, Harry <harry.van.haa...@intel.com>; Rao, Nikhil > > <nikhil....@intel.com>; hemant.agra...@nxp.com; Ma, Liang J > > <liang.j...@intel.com> > > Cc: dev@dpdk.org; Pavan Nikhilesh <pbhagavat...@caviumnetworks.com> > > Subject: [PATCH 07/13] examples/eventdev: add thread safe Tx worker pipeline > > > > Add worker pipeline when Tx is multi thread safe. > > Probe Ethernet dev capabilities and select it it is supported. > > > > Signed-off-by: Pavan Nikhilesh <pbhagavat...@caviumnetworks.com> > > <snip> > > > static void > > diff --git a/examples/eventdev_pipeline_sw_pmd/pipeline_common.h > > b/examples/eventdev_pipeline_sw_pmd/pipeline_common.h > > index a5837c99b..0b27d1eb0 100644 > > --- a/examples/eventdev_pipeline_sw_pmd/pipeline_common.h > > +++ b/examples/eventdev_pipeline_sw_pmd/pipeline_common.h > > @@ -108,6 +108,7 @@ struct config_data { > > int dump_dev_signal; > > unsigned int num_stages; > > unsigned int worker_cq_depth; > > + unsigned int rx_stride; > > Perhaps comment what "rx stride" does? The others variables are logical > enough to me, but this one I don't get.. Sure, will add comments explaining why we need rx stride. It would basically reduce congestion in entry queue when using multi ports. > > > +static int > > +setup_eventdev_w(struct prod_data *prod_data, > > + struct cons_data *cons_data, > > + struct worker_data *worker_data) > > I think this function name can be improved - what does the w mean? > I will redo the funtion name according to pipeline name. `setup_eventdev_worker_generic` `setup_eventdev_worker_tx` Pavan
