On Tue, Dec 19, 2017 at 01:27:07PM +0000, Luca Boccassi wrote: > On Tue, 2017-12-19 at 10:53 +0000, Bruce Richardson wrote: > > Add some skeleton files to enable compiling for ARM target. This has > > been > > tested by doing a cross-compile for armv8-a type using the linaro gcc > > toolchain. > > > > meson arm-build --cross-file aarch64_cross.txt > > ninja -C arm-build > > > > where aarch64_cross.txt contained the following > > > > [binaries] > > c = 'aarch64-linux-gnu-gcc' > > cpp = 'aarch64-linux-gnu-cpp' > > ar = 'aarch64-linux-gnu-ar' > > > > [host_machine] > > system = 'linux' > > cpu_family = 'aarch64' > > cpu = 'armv8-a' > > endian = 'little' > > > > It is hoped that those working on arm architecture can use this as a > > baseline > > to add arm support - both native compiled and cross-compiled - to the > > meson > > build. > > Can't comment on ARM functionality, but shouldn't the new files use > SPDX ids rather than the full license header? >
Yes, they should. However, this is just a prototype patch used to verify the cross-compile functionality of the build system and is not directly intended for merge. A proper implementation should, I think, come from those more familiar with arm architecture than I am. [Hence the CC of Jerin and Hemant on the patch]. Because of that I didn't go back to edit the license tag of the patch i.e. I was a bit lazy. :-) /Bruce