On 12/18/2017 2:13 PM, Stephen Hemminger wrote: > On Mon, 18 Dec 2017 21:06:58 +0000 > Ferruh Yigit <ferruh.yi...@intel.com> wrote: > >> diff --git a/lib/librte_eal/linuxapp/igb_uio/igb_uio.c >> b/lib/librte_eal/linuxapp/igb_uio/igb_uio.c >> index a3a98c173..d0e4fd966 100644 >> --- a/lib/librte_eal/linuxapp/igb_uio/igb_uio.c >> +++ b/lib/librte_eal/linuxapp/igb_uio/igb_uio.c >> @@ -1,25 +1,6 @@ >> /*- >> - * GPL LICENSE SUMMARY >> - * >> - * Copyright(c) 2010-2014 Intel Corporation. All rights reserved. >> - * >> - * This program is free software; you can redistribute it and/or modify >> - * it under the terms of version 2 of the GNU General Public License as >> - * published by the Free Software Foundation. >> - * >> - * This program is distributed in the hope that it will be useful, but >> - * WITHOUT ANY WARRANTY; without even the implied warranty of >> - * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU >> - * General Public License for more details. >> - * >> - * You should have received a copy of the GNU General Public License >> - * along with this program; if not, write to the Free Software >> - * Foundation, Inc., 51 Franklin St - Fifth Floor, Boston, MA 02110-1301 >> USA. >> - * The full GNU General Public License is included in this distribution >> - * in the file called LICENSE.GPL. >> - * >> - * Contact Information: >> - * Intel Corporation >> + * SPDX-License-Identifier: GPL-2.0 >> + * Copyright(c) 2010-2014 Intel Corporation. All rights reserved. >> */ >> >> #define pr_fmt(fmt) KBUILD_MODNAME ": " fmt > > SPDX looks better, and since this is a kernel file it should follow > the Linux kernel standard. > > // SPDX-License-Identifier: GPL-2.0 > /* > * Copyright(c) 2010-2014 Intel Corporation. All rights reserved. > */
OK, I will update. Is there any benefit of following Linux kernel standard not only for kernel modules but for all DPDK files? > > You might also want to do the update of year as well. >
