On Mon, Dec 18, 2017 at 11:53:57AM +0000, Harry van Haaren wrote: > This commit paves the way for the meson tests in the next > patch. With this patch the test binary checks the DPDK_TEST > environment variable and if set, the contents of the var > are inserted on the test app command line, and run. > > This allows testing of various different unit tests without > manual interaction with the RTE>> test prompt, instead automating > it using the DPDK_TEST environment variable. > > If the DPDK_TEST env variable is not set, or has zero lenght, > the test app behaves as normal. > > Signed-off-by: Harry van Haaren <harry.van.haa...@intel.com> > ---
This is very useful, even without the meson test part added in the next patch. Probably a matter of personal taste, but I think I would prefer to see the tests to be run specified as args on the cmdline rather than passed through the environment. I'd tend to view environment variables as things to use for long-lasting values, rather than parameters you might want to change between each run. Using cmdline args would also save you having to split commands, since you'd get the list pre-split in argv. /Bruce
