-----Original Message----- > Date: Thu, 7 Dec 2017 17:15:16 +0000 > From: "Van Haaren, Harry" <[email protected]> > To: "Eads, Gage" <[email protected]>, "[email protected]" <[email protected]> > CC: "[email protected]" <[email protected]>, > "Richardson, Bruce" <[email protected]>, "[email protected]" > <[email protected]>, "[email protected]" <[email protected]>, > "[email protected]" <[email protected]>, > "[email protected]" <[email protected]> > Subject: RE: [PATCH 1/2] event/sw: fix queue memory leak and multi-link bug > > > From: Eads, Gage > > Sent: Thursday, November 30, 2017 3:09 AM > > To: [email protected] > > Cc: [email protected]; Van Haaren, Harry > > <[email protected]>; Richardson, Bruce > > <[email protected]>; [email protected]; [email protected]; > > [email protected]; [email protected] > > Subject: [PATCH 1/2] event/sw: fix queue memory leak and multi-link bug > > > > This commit reinitializes a queue before it is reconfigured, such that > > reorder buffer memory is not leaked. > > > > This bug masked a few other problems, which this commit corrects as well: > > - sw_port_link() allowed a port to link to a queue twice, such that the > > port could then successfully unlink the queue twice. Now the link > > function checks whether a port is already linked to the queue, and if so > > returns success but doesn't assign the a port a second slot in the > > queue's cq map. > > - test_eventdev.c's test_eventdev_unlink() was unlinking a queue twice > > from the same port, and expecting the second unlink to succeed. Now the > > test unlinks, links, then unlinks again. > > - test_eventdev.c's test_eventdev_link_get() was linking a single queue but > > expecting the unlink function to return nb_queues (where nb_queues > 1). > > The test now checks for a return value of 1. > > > > Fixes: 5ffb2f142d95 ("event/sw: support event queues") > > Fixes: 371a688fc159 ("event/sw: support linking queues to ports") > > Fixes: f8f9d233ea0e ("test/eventdev: add unit tests") > > > > Signed-off-by: Gage Eads <[email protected]> > > Looks good to me, > > Acked-by: Harry van Haaren <[email protected]>
Cc: [email protected] Applied to dpdk-next-eventdev/master. Thanks.
