> -----Original Message----- > From: zhouyangchao [mailto:zhouya...@gmail.com] > Sent: Monday, December 4, 2017 2:38 PM > To: dev@dpdk.org > Cc: Zhang, Qi Z <qi.z.zh...@intel.com>; Zhang, Qi Z <qi.z.zh...@intel.com> > Subject: [PATCH] net/fm10k: remove RSS restriction with num of queues > > FM10K HW does not have such restrictions. > > Enabling RSS with single queue is not used to distribute flow but to compute > a RSS hash value. > It can reduce cpu cycles of computing a hash value with five tuples. > In addition, there is an explicit method to disable RSS instead of an obscure > way. > > Signed-off-by: Yangchao Zhou <zhouya...@gmail.com> > --- > drivers/net/fm10k/fm10k_ethdev.c | 5 ++--- > 1 file changed, 2 insertions(+), 3 deletions(-) > > diff --git a/drivers/net/fm10k/fm10k_ethdev.c > b/drivers/net/fm10k/fm10k_ethdev.c > index 2d05a46..403f6c5 100644 > --- a/drivers/net/fm10k/fm10k_ethdev.c > +++ b/drivers/net/fm10k/fm10k_ethdev.c > @@ -533,9 +533,8 @@ fm10k_dev_rss_configure(struct rte_eth_dev *dev) > 0x6A, 0x42, 0xB7, 0x3B, 0xBE, 0xAC, 0x01, 0xFA, > }; > > - if (dev->data->nb_rx_queues == 1 || > - dev_conf->rxmode.mq_mode != ETH_MQ_RX_RSS || > - dev_conf->rx_adv_conf.rss_conf.rss_hf == 0) { > + if (dev_conf->rxmode.mq_mode != ETH_MQ_RX_RSS || > + dev_conf->rx_adv_conf.rss_conf.rss_hf == 0) { > FM10K_WRITE_REG(hw, FM10K_MRQC(0), 0); > return; > } > -- > 2.9.0.windows.1 > > Acked-by: Qi Zhang <qi.z.zh...@intel.com>
Regards Qi
