On 11/23/2017 4:08 AM, Shahaf Shuler wrote: > Since testpmd is now using the new Ethdev offloads API there is no > need for the txqflags configuration.
txqflag command-line option (--txqflags=0xXXXXXXXX) and command (port config all txqflags value) are way to dynamically provide Tx offload configuration to testpmd. Why you are removing them without providing equivalent feature with new offload APIs? Patch 3/4 & 4/5 adds new command-line options to enable some of recently introduced Tx offloads in testpmd, why not add a generic way to update all Tx offloads instead of those two specific offloads? Also this patch removing ability to display current Tx offload configuration.... > > Signed-off-by: Shahaf Shuler <shah...@mellanox.com> > Acked-by: Nelio Laranjeiro <nelio.laranje...@6wind.com> <...>
