On 11/23/2017 10:33 PM, Jingjing Wu wrote: > Signed-off-by: Jingjing Wu <jingjing...@intel.com>
<...> > @@ -37,6 +37,7 @@ ifeq ($(CONFIG_RTE_LIBRTE_THUNDERX_NICVF_PMD),d) > endif > > DIRS-$(CONFIG_RTE_LIBRTE_PMD_AF_PACKET) += af_packet > +DIRS-$(CONFIG_RTE_LIBRTE_AVF_PMD) += avf Can you please add this alphabetically? <...> > +OBJS_BASE_DRIVER=$(patsubst %.c,%.o,$(notdir $(wildcard $(SRCDIR)/base/*.c))) > +$(foreach obj, $(OBJS_BASE_DRIVER), $(eval > CFLAGS_$(obj)+=$(CFLAGS_BASE_DRIVER))) There is no CFLAGS_BASE_DRIVER yet, you can add these lines when some CFLAGS_BASE_DRIVER added. <...> > @@ -37,7 +37,7 @@ > extern int avf_logtype_init; > #define PMD_INIT_LOG(level, fmt, args...) \ > rte_log(RTE_LOG_ ## level, avf_logtype_init, "%s(): " fmt "\n", \ > - __func__, ##args) > + __func__, ## args) Can you please squash this one to previous patch? <...> > +/** > + * avf_check_api_version > + * @dev: pointer to eth device There is no "dev" parameter to the API. <...> > @@ -120,6 +120,7 @@ _LDLIBS-$(CONFIG_RTE_DRIVER_MEMPOOL_STACK) += > -lrte_mempool_stack > _LDLIBS-$(CONFIG_RTE_LIBRTE_PMD_AF_PACKET) += -lrte_pmd_af_packet > _LDLIBS-$(CONFIG_RTE_LIBRTE_ARK_PMD) += -lrte_pmd_ark > _LDLIBS-$(CONFIG_RTE_LIBRTE_AVP_PMD) += -lrte_pmd_avp > +_LDLIBS-$(CONFIG_RTE_LIBRTE_AVF_PMD) += -lrte_pmd_avf Can you please add this alphabetically?
