Re: [dpdk-dev] [dpdk-stable] [PATCH 42/53] net/sfc/base: fix probes in licensing support

[Andrew Rybchenko]

On 11/27/2017 10:58 PM, Ferruh Yigit wrote:

On 11/16/2017 12:04 AM, Andrew Rybchenko wrote:

From: Mark Spender <mspen...@solarflare.com>

What has been fixed here?
If you can provide more details I can amend the commit later.

EFSYS_PROBE1 takes one typed value (in addition to the probe name),
whereas EFSYS_PROBE has just the probe name.

Which to use is determined by the probe name – “fail1” probes are
expected to include the function result.

Thanks,
Andrew.

Fixes: 05fce2ce8451 ("net/sfc/base: import libefx licensing")
Cc: sta...@dpdk.org

Signed-off-by: Mark Spender <mspen...@solarflare.com>
Signed-off-by: Andrew Rybchenko <arybche...@solarflare.com>
---
  drivers/net/sfc/base/efx_lic.c | 6 +++---
  1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/drivers/net/sfc/base/efx_lic.c b/drivers/net/sfc/base/efx_lic.c
index de25c5c..cfff51a 100644
--- a/drivers/net/sfc/base/efx_lic.c
+++ b/drivers/net/sfc/base/efx_lic.c
@@ -498,7 +498,7 @@ efx_lic_v1v2_find_key(
        return (found);

fail1:

-       EFSYS_PROBE(fail1);
+       EFSYS_PROBE1(fail1, boolean_t, B_FALSE);

return (B_FALSE);

  }
@@ -540,7 +540,7 @@ efx_lic_v1v2_validate_key(
  fail2:
        EFSYS_PROBE(fail2);
  fail1:
-       EFSYS_PROBE(fail1);
+       EFSYS_PROBE1(fail1, boolean_t, B_FALSE);

return (B_FALSE);

  }
@@ -1158,7 +1158,7 @@ efx_lic_v3_validate_key(
  fail2:
        EFSYS_PROBE(fail2);
  fail1:
-       EFSYS_PROBE(fail1);
+       EFSYS_PROBE1(fail1, boolean_t, B_FALSE);

return (B_FALSE);

  }