On 11/9/2017 8:05 PM, Stephen Hemminger wrote: > On Thu, 9 Nov 2017 17:10:16 -0800 > Ferruh Yigit <ferruh.yi...@intel.com> wrote: > >> On 11/8/2017 3:59 AM, Alejandro Lucero wrote: >>> Not all struct fields will be written and random data could >>> confuse readers. >>> >>> Fixes: 92aa491b881e ("nfp: add statistics") >>> Coverity: 140755 >> >> Hi Alejandro, >> >> Thank you for coverity fixes, but they will be considered for next release, >> since trying to limit rc4 only for critical fixes. >> >> Thanks, >> ferruh >> >>> >>> Signed-off-by: Alejandro Lucero <alejandro.luc...@netronome.com> >> > > This looks like a bug fix. because the stats are on the stack and will > be garbage.
Yes it is, also other nfp patches are fixes. This is for an effort to close the release, eventually it needs to stop somewhere, and technically after rc3 is only for critical bug fixes, so this is the time for stop getting these kind of patches. After above said, relying on scope of the patches are PMD only and patches are sent by driver maintainers, I will get them, reminding Thomas' right to drop them back if he disagrees.